Skip to content

1478 Fix TorchScript issue in AHnet#1479

Merged
wyli merged 3 commits into
Project-MONAI:masterfrom
Nic-Ma:1478-fix-torchscript-ahnet
Jan 21, 2021
Merged

1478 Fix TorchScript issue in AHnet#1479
wyli merged 3 commits into
Project-MONAI:masterfrom
Nic-Ma:1478-fix-torchscript-ahnet

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

Fixes #1478 .

Description

This PR fixed the TorchScript issue in AHNet when num_block_psp=0.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 2 commits January 21, 2021 18:19
@Nic-Ma

Nic-Ma commented Jan 21, 2021

Copy link
Copy Markdown
Contributor Author

/black

@wyli

wyli commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

thanks, could you add a test case to cover this change?

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jan 21, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 21, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments.
Could you please help review it again?

Thanks.

@wyli wyli merged commit c9d15f1 into Project-MONAI:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TorchScript can't work for AHNet when num_psp=0

2 participants